From: Ernestas Kulik <ernestask@gnome.org>
Date: Thu, 30 Mar 2017 19:29:57 +0000 (+0300)
Subject: flowbox: don’t select when rubberbanding over nothing
X-Git-Tag: archive/raspbian/3.24.39-1+rpi1~1^2~65^2~39^2~649
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=69234066a4dff142d50944daa32748234debdebb;p=gtk%2B3.0.git

flowbox: don’t select when rubberbanding over nothing

When rubberbanding over an empty area, everything is selected on gesture
end, which is a bit counter-intuitive.

https://bugzilla.gnome.org/show_bug.cgi?id=780735
---

diff --git a/gtk/gtkflowbox.c b/gtk/gtkflowbox.c
index a6fcd1d877..24af737882 100644
--- a/gtk/gtkflowbox.c
+++ b/gtk/gtkflowbox.c
@@ -3139,7 +3139,9 @@ gtk_flow_box_drag_gesture_end (GtkGestureDrag *gesture,
       if (!priv->rubberband_extend && !priv->rubberband_modify)
         gtk_flow_box_unselect_all_internal (box);
 
-      gtk_flow_box_select_all_between (box, priv->rubberband_first, priv->rubberband_last, priv->rubberband_modify);
+      if (priv->rubberband_first && priv->rubberband_last)
+        gtk_flow_box_select_all_between (box, priv->rubberband_first, priv->rubberband_last, priv->rubberband_modify);
+
       gtk_flow_box_stop_rubberband (box);
 
       g_signal_emit (box, signals[SELECTED_CHILDREN_CHANGED], 0);